Skip to content

197 email#238

Merged
SamNie2027 merged 6 commits intomainfrom
197-email
Apr 12, 2026
Merged

197 email#238
SamNie2027 merged 6 commits intomainfrom
197-email

Conversation

@anjalisilina
Copy link
Copy Markdown

ℹ️ Issue

Closes #197

📝 Description

Briefly list the changes made to the code:

  1. Created an updateStatus method that calls the email controller when an application status is changed
  2. Created constants for the email subjects and bodies
  3. Added unit tests and mocked the email service for application status change

✔️ Verification

Used postman to test sending emails:
Screenshot 2026-04-07 at 11 14 06 PM
Screenshot 2026-04-07 at 11 14 20 PM
Screenshot 2026-04-07 at 11 14 32 PM

All unit tests passed:
435F4989-BCB7-4F1A-B1B9-E8236F9A7DE9
B17EC005-606B-4775-8A8E-EAB4C2B8D8AB

🏕️ (Optional) Future Work / Notes

Application doesn't have fields for first or last names, so I just had the email say "Hello Applicant"

@SamNie2027 SamNie2027 self-requested a review April 9, 2026 11:48
@SamNie2027
Copy link
Copy Markdown
Collaborator

The first and last names are in candidateInfo

Copy link
Copy Markdown
Collaborator

@SamNie2027 SamNie2027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just get the first name and last name from candidate info and you're good, this is great thank you!

@anjalisilina anjalisilina requested a review from SamNie2027 April 12, 2026 19:48
Copy link
Copy Markdown
Collaborator

@SamNie2027 SamNie2027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@SamNie2027 SamNie2027 merged commit fdfd316 into main Apr 12, 2026
5 checks passed
@SamNie2027 SamNie2027 deleted the 197-email branch April 12, 2026 21:20
SamNie2027 added a commit that referenced this pull request Apr 12, 2026
commit 23de16a
Merge: fdfd316 c81632d
Author: Sam Nie <[email protected]>
Date:   Sun Apr 12 17:44:11 2026 -0400

    Merge pull request #247 from Code-4-Community/rm-224-remove-experienceType

    remove experience type

commit c81632d
Author: Rayyan Mridha <[email protected]>
Date:   Sun Apr 12 17:40:34 2026 -0400

    add back necessary old migrations

commit 5412533
Author: Sam Nie <[email protected]>
Date:   Sun Apr 12 17:34:10 2026 -0400

    Removing from profile header

commit fb960de
Author: Rayyan Mridha <[email protected]>
Date:   Sun Apr 12 17:26:36 2026 -0400

    remove more migration related stuff

commit fdfd316
Merge: 8773000 6f3ee16
Author: Sam Nie <[email protected]>
Date:   Sun Apr 12 17:20:37 2026 -0400

    Merge pull request #238 from Code-4-Community/197-email

    197 email

commit 838a707
Author: Rayyan Mridha <[email protected]>
Date:   Sun Apr 12 17:20:17 2026 -0400

    Update AdminViewApplication.tsx

commit 07b0c93
Merge: 163b3fc 8773000
Author: Rayyan Mridha <[email protected]>
Date:   Sun Apr 12 17:19:53 2026 -0400

    Merge branch 'main' into rm-221-pandadoc-webhook-create-app

commit 6f3ee16
Author: Sam Nie <[email protected]>
Date:   Sun Apr 12 17:17:19 2026 -0400

    Name capitalization and fallback.

commit 163b3fc
Author: Rayyan Mridha <[email protected]>
Date:   Sun Apr 12 17:08:12 2026 -0400

    Remove experienceType field from the entire codebase

    The experienceType field is no longer needed for applications. This removes
    the ExperienceType enum, entity column, DTO field, frontend filter/table
    column, seed data, test references, and Postman payloads. Adds a migration
    to drop the column and enum type from the database.

    Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

commit 8687e41
Merge: 76e1b07 8773000
Author: Sam Nie <[email protected]>
Date:   Sun Apr 12 17:03:11 2026 -0400

    Merge branch 'main' into 197-email

commit 8773000
Merge: 54952d5 ba40b54
Author: Rayyan Mridha <[email protected]>
Date:   Sun Apr 12 16:53:41 2026 -0400

    Merge pull request #245 from Code-4-Community/feature/195-application-profile-frame

    application profile frame

commit ba40b54
Merge: f622973 54952d5
Author: Rayyan Mridha <[email protected]>
Date:   Sun Apr 12 16:49:15 2026 -0400

    merge main

commit f622973
Author: Rayyan Mridha <[email protected]>
Date:   Sun Apr 12 16:40:27 2026 -0400

    readd auth guards

commit be15d48
Author: alveenahanif <[email protected]>
Date:   Sun Apr 12 16:14:16 2026 -0400

    implemented application profile header

commit 76e1b07
Author: anjalisilina <[email protected]>
Date:   Sun Apr 12 15:26:16 2026 -0400

    added first and last name

commit e10d339
Author: alveenahanif <[email protected]>
Date:   Sun Apr 12 15:08:59 2026 -0400

    fixed is legal adult

commit 54952d5
Merge: 609eb33 829fbd9
Author: Rayyan Mridha <[email protected]>
Date:   Sun Apr 12 13:51:08 2026 -0400

    Merge pull request #236 from Code-4-Community/188-auth4

    188 auth4

commit 829fbd9
Author: Sam Nie <[email protected]>
Date:   Sun Apr 12 11:24:35 2026 -0400

    Feedback

commit 2cc3094
Merge: 032f74c 609eb33
Author: Sam Nie <[email protected]>
Date:   Sun Apr 12 11:10:51 2026 -0400

    Merging main in

commit 609eb33
Merge: 2ae1e46 a21632a
Author: Rayyan Mridha <[email protected]>
Date:   Thu Apr 9 18:29:57 2026 -0400

    Merge pull request #234 from Code-4-Community/230-status-change

    Application Status Change + Forms Sent -> Forms Signed

commit 5a18bcc
Author: alveenahanif <[email protected]>
Date:   Wed Apr 8 00:45:15 2026 -0400

    fixed format of profile header

commit 4bceaf7
Author: alveenahanif <[email protected]>
Date:   Wed Apr 8 00:37:07 2026 -0400

    Update applicant header layout

commit 22acbe0
Author: alveenahanif <[email protected]>
Date:   Wed Apr 8 00:30:07 2026 -0400

    added header back

commit 8ace5f1
Author: alveenahanif <[email protected]>
Date:   Tue Apr 7 23:44:12 2026 -0400

    clean up header styling

commit 4ddd6d4
Author: alveenahanif <[email protected]>
Date:   Tue Apr 7 23:35:53 2026 -0400

    update header layout and add person icon

commit 7f225e4
Author: anjalisilina <[email protected]>
Date:   Tue Apr 7 23:11:31 2026 -0400

    controller spec tests

commit 7f2b913
Author: anjalisilina <[email protected]>
Date:   Tue Apr 7 23:07:14 2026 -0400

    service spec tests

commit 80270e8
Author: anjalisilina <[email protected]>
Date:   Tue Apr 7 17:45:53 2026 -0400

    email when status change

commit f8920bf
Merge: e97cc0c 2ae1e46
Author: alveenahanif <[email protected]>
Date:   Tue Apr 7 12:13:13 2026 -0400

    add VolunteerInfo type and getVolunteerInfo API method

commit e97cc0c
Author: alveenahanif <[email protected]>
Date:   Tue Apr 7 11:52:34 2026 -0400

    save local changes before pulling main

commit 032f74c
Author: Sam Nie <[email protected]>
Date:   Mon Apr 6 22:16:52 2026 -0400

    Mocking auth for frontend tests

commit ba1adc5
Author: Sam Nie <[email protected]>
Date:   Mon Apr 6 22:07:34 2026 -0400

    Fixed auth bug

commit bb6236d
Author: Sam Nie <[email protected]>
Date:   Mon Apr 6 21:45:10 2026 -0400

    Fixed import

commit 331aa51
Merge: ca2875b 2ae1e46
Author: Sam Nie <[email protected]>
Date:   Mon Apr 6 21:31:40 2026 -0400

    Merge branch 'main' into 188-auth4

commit a21632a
Merge: 1dc1776 2ae1e46
Author: Sam Nie <[email protected]>
Date:   Mon Apr 6 21:28:57 2026 -0400

    Merge branch 'main' into 230-status-change

commit 2ae1e46
Merge: a67cdca 434458c
Author: Sam Nie <[email protected]>
Date:   Mon Apr 6 21:21:42 2026 -0400

    Merge pull request #237 from Code-4-Community/frontend-test-cicd

    Frontend test cicd

commit 434458c
Merge: ceba39d a67cdca
Author: Sam Nie <[email protected]>
Date:   Mon Apr 6 21:18:21 2026 -0400

    Merge branch 'main' into frontend-test-cicd

commit a67cdca
Merge: 4b15284 be1a212
Author: Sam Nie <[email protected]>
Date:   Mon Apr 6 21:14:33 2026 -0400

    Merge pull request #209 from Code-4-Community/pandadoc-form-mapping

    Pandadoc form mapping

commit be1a212
Author: Sam Nie <[email protected]>
Date:   Mon Apr 6 21:10:57 2026 -0400

    Removing VolunteerInfo

commit ceba39d
Merge: d78ad04 4b15284
Author: chnnick <[email protected]>
Date:   Mon Apr 6 14:03:47 2026 -0400

    Merge branch 'main' of https://github.com/Code-4-Community/proj-bhchp into frontend-test-cicd

commit d78ad04
Author: chnnick <[email protected]>
Date:   Mon Apr 6 14:02:55 2026 -0400

    Add mock API client for App tests to avoid calling to real backend

commit 78918aa
Author: chnnick <[email protected]>
Date:   Mon Apr 6 14:00:11 2026 -0400

    Refactor AdminLanding tests to use a mock API client module for consistent dashboard counts, resolves connection error

commit b6b51fb
Author: chnnick <[email protected]>
Date:   Mon Apr 6 01:00:53 2026 -0400

    Updated comment for BHCHP test to say its just in the component, not the sidebar

commit 91e4930
Author: chnnick <[email protected]>
Date:   Mon Apr 6 00:42:06 2026 -0400

    frontend title test fix + basic yaml for running frontend tests

commit 1dc1776
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 21:58:26 2026 -0400

    Update vite.config.ts

commit bde9cb5
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 21:49:40 2026 -0400

    Improve PandaDoc mapping and normalize school labels

commit 4b15284
Merge: 6f455a0 87ac3ae
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 21:13:26 2026 -0400

    Merge pull request #225 from Code-4-Community/rm-207-filter-pop-up

    Filter Pop Up in Admin View

commit 87ac3ae
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 21:10:12 2026 -0400

    Changing placeholder date order

commit ca2875b
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 20:55:13 2026 -0400

    Update applications.controller.spec.ts

commit e689afe
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 20:54:42 2026 -0400

    Update applications.controller.spec.ts

commit 5d91f61
Merge: 3e90355 6f455a0
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 20:47:05 2026 -0400

    Merge branch 'main' into 188-auth4

commit 6f455a0
Merge: 8fcbcb2 648689b
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 20:44:22 2026 -0400

    Merge pull request #227 from Code-4-Community/212-error-email

    212 error email

commit 3e90355
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 19:51:49 2026 -0400

    Adding more to exmaple.env

commit 8079ef9
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 19:40:03 2026 -0400

    Error handling

commit b40f6f4
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 18:17:53 2026 -0400

    WIP frontend

commit 54285fc
Author: Sam Nie <[email protected]>
Date:   Sun Apr 5 16:46:30 2026 -0400

    JWT Strategy, Roles Guard, improved AWS Exports, and reorganization

commit 648689b
Author: chnnick <[email protected]>
Date:   Sat Apr 4 22:50:46 2026 -0400

    tests for validation filters that run in the HTTP Pipeline when endpoints receive DTO information

commit 168d9fd
Merge: 158859f 8fcbcb2
Author: chnnick <[email protected]>
Date:   Sat Apr 4 18:59:06 2026 -0400

    Merge branch 'main' of https://github.com/Code-4-Community/proj-bhchp into 212-error-email

commit 4696180
Author: Rayyan Mridha <[email protected]>
Date:   Sat Apr 4 18:04:20 2026 -0400

    fix enums

commit 7cc3d34
Author: alveenahanif <[email protected]>
Date:   Sat Apr 4 13:18:32 2026 -0400

    Initial Profile

commit 85f5aef
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 22:48:10 2026 -0400

    Reorganisation

commit 7fabed8
Merge: b90fe17 f7d1863
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 22:41:25 2026 -0400

    Merge branch 'pandadoc-form-mapping' of https://github.com/Code-4-Community/proj-bhchp into pandadoc-form-mapping

commit b90fe17
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 22:39:20 2026 -0400

    Using school options from pandadoc

commit f7d1863
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 22:12:08 2026 -0400

    Apply suggestion from @Copilot

    Co-authored-by: Copilot <[email protected]>

commit 4c07b76
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 22:02:12 2026 -0400

    EST

commit 751b8e1
Merge: ddcff7e 7d34b33
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 21:58:11 2026 -0400

    Merge branch 'pandadoc-form-mapping' of https://github.com/Code-4-Community/proj-bhchp into pandadoc-form-mapping

commit ddcff7e
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 21:57:59 2026 -0400

    Parse MM-DD-YYYY as UTC midnight; fix mappings

commit 7d34b33
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 21:50:54 2026 -0400

    Update apps/backend/src/panda-field-map.ts

    Co-authored-by: Copilot <[email protected]>

commit be41753
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 21:45:30 2026 -0400

    Update apps/backend/src/pandadoc-mapper.ts

    Co-authored-by: Copilot <[email protected]>

commit fea46e8
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 21:44:05 2026 -0400

    Require explicit array aggregation in PandaDoc map

commit 5a20237
Merge: 9ff2a0b 08486c6
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 21:29:13 2026 -0400

    Merge branch 'pandadoc-form-mapping' of https://github.com/Code-4-Community/proj-bhchp into pandadoc-form-mapping

commit 9ff2a0b
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 21:28:30 2026 -0400

    Add PandaDoc volunteer mappings and parsing helpers

commit 08486c6
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 20:13:43 2026 -0400

    Update apps/backend/src/panda-field-map.ts

    Co-authored-by: Copilot <[email protected]>

commit 158859f
Author: chnnick <[email protected]>
Date:   Fri Apr 3 17:54:41 2026 -0400

    changed order of which filters run first, running badexception filter before app validation (NestJS reverses the order) no longer need to check for badrequestexception in the second filter

commit 31ae468
Author: chnnick <[email protected]>
Date:   Fri Apr 3 16:51:51 2026 -0400

    took out usersservice and emailsservice in application service emailservice usage is moved to the filters

commit 8f7896c
Author: chnnick <[email protected]>
Date:   Fri Apr 3 16:49:49 2026 -0400

    generic error filter that sends emails to recipients if they have an error when processing email past the DTO validation stage + moved filters to filter folder

commit f39670a
Author: chnnick <[email protected]>
Date:   Fri Apr 3 16:31:27 2026 -0400

    fully took out use of UserService, abstracted out logic for catching error, then sending submission-error-email

commit fd48b32
Author: chnnick <[email protected]>
Date:   Fri Apr 3 13:46:43 2026 -0400

    No longer fetches for user + name in user module, instead just defaults to the name "Applicant"

commit 5f4dd3c
Author: chnnick <[email protected]>
Date:   Fri Apr 3 13:26:15 2026 -0400

    Documentation

commit 63d12a1
Author: Sam Nie <[email protected]>
Date:   Fri Apr 3 09:08:28 2026 -0400

    Application Status Change + Forms Sent -> Forms Signed

commit 93db592
Author: Owen Stepan <[email protected]>
Date:   Wed Apr 1 13:34:02 2026 -0400

    updates for new backend

commit eb701cb
Merge: 55ce063 8fcbcb2
Author: Sam Nie <[email protected]>
Date:   Wed Apr 1 08:53:42 2026 -0400

    Merge branch 'main' into pandadoc-form-mapping

commit 8fcbcb2
Merge: ff590f6 4a590be
Author: Sam Nie <[email protected]>
Date:   Wed Apr 1 08:02:06 2026 -0400

    Merge pull request #226 from Code-4-Community/144-emergency-frame

    created emergency contact frame + added to admin view

commit 2d7d1d9
Author: chnnick <[email protected]>
Date:   Wed Apr 1 01:04:05 2026 -0400

    put mapping in types.ts, make error messages in email much more human-readable

commit e4c34ba
Author: chnnick <[email protected]>
Date:   Wed Apr 1 00:24:43 2026 -0400

    created a filter, moved email logic to filter for bad-request-exception thrown by class validator in DTO

commit 4a590be
Author: anjalisilina <[email protected]>
Date:   Tue Mar 31 23:17:32 2026 -0400

    created emergency contact frame + added to admin view

commit 331a5b1
Author: chnnick <[email protected]>
Date:   Tue Mar 31 21:21:32 2026 -0400

    logic in between validation error caught and sending error, now sends email with hardcoded pandadoc links.

    sanitized output with escapeHTML

commit 36b5fa8
Merge: 9b55c86 ff590f6
Author: Rayyan Mridha <[email protected]>
Date:   Tue Mar 31 21:07:51 2026 -0400

    Merge branch 'main' into rm-207-filter-pop-up

commit 9b55c86
Author: Rayyan Mridha <[email protected]>
Date:   Tue Mar 31 21:06:30 2026 -0400

    add filter pop changes

    - refactor variants for status pills
    - add filter pop up component
    - fix application table scrolling in admin view

commit c48bfeb
Author: chnnick <[email protected]>
Date:   Tue Mar 31 21:05:42 2026 -0400

    bring in users and email utility modules

commit ff590f6
Merge: 3b57521 1e3e457
Author: Sam Nie <[email protected]>
Date:   Tue Mar 31 20:43:03 2026 -0400

    Merge pull request #218 from Code-4-Community/bg-integrate-app-numbers

    Created API endpoints and React hooks for application cards

commit 1e3e457
Merge: 7af2a7b 3b57521
Author: Sam Nie <[email protected]>
Date:   Tue Mar 31 20:34:52 2026 -0400

    Merge branch 'main' into bg-integrate-app-numbers

commit 3b57521
Merge: 71350a6 95b49c3
Author: Sam Nie <[email protected]>
Date:   Tue Mar 31 20:33:21 2026 -0400

    Merge pull request #224 from Code-4-Community/bg-214-aws-s3-environment-variables

    Added AWS S3 Enviornment Variable and Updated Components

commit 95b49c3
Author: Sam Nie <[email protected]>
Date:   Tue Mar 31 20:29:21 2026 -0400

    Update seed.ts

commit b504cb8
Author: Sam Nie <[email protected]>
Date:   Tue Mar 31 20:11:23 2026 -0400

    Adding a syllabus file

commit e9c256e
Author: bodhiYG <[email protected]>
Date:   Tue Mar 31 05:27:13 2026 -0400

    Added AWS S3 Enviornment Variable and Updated Components

commit 7af2a7b
Author: bodhiYG <[email protected]>
Date:   Tue Mar 31 04:44:23 2026 -0400

    Resolved PR Comments

commit 89857e3
Author: Sam Nie <[email protected]>
Date:   Tue Mar 24 15:33:51 2026 -0400

    Added Rejected and Approved user in the seed

commit d740542
Author: Sam Nie <[email protected]>
Date:   Tue Mar 24 11:04:58 2026 -0400

    Apply suggestion from @Copilot to remove whitespace

    Co-authored-by: Copilot <[email protected]>

commit 0e1cde7
Author: bodhiYG <[email protected]>
Date:   Tue Mar 24 02:49:08 2026 -0400

    Created API endpoints and React hooks for application cards

commit 55ce063
Author: Owen Stepan <[email protected]>
Date:   Wed Mar 18 15:50:01 2026 -0400

    final changes

commit bec1e33
Author: Owen Stepan <[email protected]>
Date:   Mon Mar 16 19:25:08 2026 -0400

    initial implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Send email when applicant is accepted, rejected, no availability,

3 participants